Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable INP Ruff checks #1501

Merged
merged 1 commit into from
Mar 16, 2023
Merged

chore: Enable INP Ruff checks #1501

merged 1 commit into from
Mar 16, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 15, 2023

Rationale

Implicit namespace packages are directories of Python files without an __init__.py. They’re valid and importable, but they break many tools, such as:

https://pypi.org/project/flake8-no-pep420/


📚 Documentation preview 📚: https://meltano-sdk--1501.org.readthedocs.build/en/1501/

<h2>Rationale</h2>

<p>Implicit namespace packages are directories of Python files without an <code>__init__.py</code>.
    They’re valid and importable, but they break <em>many</em> tools, such as:</p>

<ul>
    <li><p><a href="https://bugs.python.org/issue23882" rel="nofollow">unittest test discovery</a> (and by extension, Django’s test runner)</p></li>
    <li><p><a href="nedbat/coveragepy#1024" rel="nofollow">Coverage.py</a></p></li>
    <li><p>Mypy without its <a href="https://mypy.readthedocs.io/en/latest/command_line.html#import-discovery" rel="nofollow">–namespace-packages option</a></p></li>
    <li><p><a href="pytest-dev/pytest#5147" rel="nofollow">pytest</a></p></li>
</ul>

https://pypi.org/project/flake8-no-pep420/
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1501 (b8691f3) into main (86e3b37) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1501   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          57       57           
  Lines        4760     4760           
  Branches      813      813           
=======================================
  Hits         4070     4070           
  Misses        498      498           
  Partials      192      192           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon merged commit ee2552a into main Mar 16, 2023
@edgarrmondragon edgarrmondragon deleted the chore/enable-ruff-INP branch March 16, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants